Refactor OptionParser#parse
#16233
Merged
Refactor OptionParser#parse
#16233
+91
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Oct 27, 2025
|
These method names may not be ideal.
|
Sija
reviewed
Oct 28, 2025
ysbaddaden
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request refactors part of the
OptionParser#parsemethod into three private methods:parse_arg_to_flag_and_valuehandle_flagremove_handled_argsThe intention is that this change does not alter the program’s behavior in any way.
This refactoring is a preparatory step toward enabling short option combinations.
#10981
Thank you.